Add Rubocop configuration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanmaguire
commented
Jul 27, 2020
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2020 InterExchange. | |||
There was a problem hiding this comment.
Is this fine for a copyright?
jordanmaguire
force-pushed
the
initial_configuration
branch
from
bfd41b1 to
f548fab
Compare
jordanmaguire
force-pushed
the
initial_configuration
branch
from
d946bf0 to
ac2e0ef
Compare
jordanmaguire
commented
Jul 27, 2020
| spec.name = "iex-style" | ||
| spec.version = "1.0.0" | ||
| spec.authors = ["InterExchange"] | ||
| spec.email = ["[email protected]"] |
There was a problem hiding this comment.
We cool with this as an email? I'm sure we can simply omit one as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody
Now that we have a second Rails app on the horizon, I'm taking some time up front to share our configuration where possible, so both apps have access to all the cool stuff we've built.
In this case, I'm starting small with just sharing the Rubocop config.
Here's what App integration looks like: https://github.com/interexchange/app/pull/4486
The downside to sharing configs is that now we have to start maintaining our configuration repos as well as App. Since I've chosen to make Rubocop a dependency of this gem, we will need to upgrade it here.