Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: replace fs.readFileSync #684

Closed
wants to merge 3 commits into from
Closed

Refactor: replace fs.readFileSync #684

wants to merge 3 commits into from

Conversation

bvotteler
Copy link
Contributor

Replace fs.readFileSync which causes issues in our UI with a require workaround to be able to import definitions.json from interbtc-types.

Changed module from es6 to esnext - the latter supports createRequire(import.meta.url)

@bvotteler bvotteler requested a review from peterslany September 1, 2023 00:33
@bvotteler
Copy link
Contributor Author

Closing PR: This approach will not work as ts-jest does not support it.

@bvotteler bvotteler closed this Sep 1, 2023
@bvotteler bvotteler deleted the refactor--remove-fs.readFileSync branch September 12, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterslany peterslany Awaiting requested review from peterslany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bvotteler