Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(background): close popup on right time #820

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(background): close popup on right time #820

merged 1 commit into from
Jan 10, 2025

Conversation

sidvishnoi
Copy link
Member

Context

Closes #818

Changes proposed in this pull request

  • Close popup right before adding public key (opens or navigates tab)
  • Close popup right before getting interaction hash (opens or navigates tab)
  • Rename wallet.close_popup event to request_popup_close.

@sidvishnoi sidvishnoi requested a review from DarianM January 10, 2025 08:53
@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Extension builds preview

Name Link
Latest commit fea488e
Latest job logs Run #12706282884
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi merged commit 9eca211 into main Jan 10, 2025
9 checks passed
@sidvishnoi sidvishnoi deleted the popup-close-bug branch January 10, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM DarianM approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup closes on connect when key not added already
2 participants
@sidvishnoi @DarianM