New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle adapter to parse flag according to input or output adapter #21

Merged

riteshnoronha merged 1 commit into main from fix/adapter_related_stuffs

Feb 5, 2025

Contributor

viveksahu26 commented Feb 5, 2025 •

edited

Loading

This PR introduces 2 major fixes:

Resolves import cycle issues by extracting common types (AdapterRole, AdapterType) into a new package: types.
Fixes strict input/output adapter assumptions:

Right now, our code assumes:
- GitHub is always the input adapter (--in- flags).
- Interlynk is always the output adapter (--out- flags).
But, Interlynk can be both (input & output), meaning:
- If Interlynk is the input adapter, it should parse --in- flags.
- If Interlynk is the output adapter, it should parse --out- flags.

Therefore, allowing GitHub and Interlynk adapters to act as both input and output, dynamically.


          handle adapter to parse flag according to input or output adapter

01cfa54

Signed-off-by: Vivek Kumar Sahu <[email protected]>

viveksahu26 requested a review from riteshnoronha

February 5, 2025 20:34

riteshnoronha merged commit 16c8fee into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet