Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor/improve redability #48

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

viveksahu26
Copy link
Contributor

@viveksahu26 viveksahu26 commented Feb 14, 2025

This PR add the following changes:

  • dry-mode

    • Introduced dryRun() function to separate dry-run logic from the main transfer flow.
    • remove version from project name in dry-mode
  • Refactored Adapter Role Handling

    • Removed explicit role parameter, deriving it dynamically from config.
  • Applied SOLID Principles to NewGitHubIterator

    • NewGitHubIterator() only initializes the iterator.
    • HandleSBOMFetchingViaIterator() separates SBOM retrieval logic from NewGitHubIterator() to follow SOLID principle, as it's says one function for one reason.
  • Fix token issue while fetching all repositories

@riteshnoronha riteshnoronha merged commit 42ba88f into main Feb 14, 2025
1 check passed
@riteshnoronha riteshnoronha deleted the refractor/improve_redability branch February 14, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants