Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor, cleanup, centralizing variables and function #55

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

viveksahu26
Copy link
Contributor

This PR adds the following changes:

  • Globalized GitHub Adapter Utility Functions:

    • Moved GitHub-specific utility functions to a shared location under "source", ensuring reusability across all source adapters.
    • This prevents code duplication and adheres to the DRY (Don't Repeat Yourself) principle.
  • Replaced repo with Namespace in SBOM Assets:

    • Previously, repo was used to differentiate SBOMs when fetching from an organization, treating each repository as a separate entity.
    • However, to make sbommv more generic and extensible for all adapters, we replaced repo with Namespace.
    • So, now it can be used for differentiating SBOMs from repositories (GitHub) or directories (Folder Adapter).
  • Globalized Interlynk Adapter Variables such as UploadSettings and UploadMode, so that other output adapter can resuse this.

@viveksahu26 viveksahu26 changed the title Fix/GitHub utils fn Refractor, cleanup, centralizing variables and function Feb 19, 2025
@riteshnoronha riteshnoronha merged commit 6e29a03 into main Feb 20, 2025
1 check passed
@riteshnoronha riteshnoronha deleted the fix/github_utils_fn branch February 20, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants