Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ndt7 measurement #49

Merged
merged 4 commits into from
Jun 12, 2023
Merged

add ndt7 measurement #49

merged 4 commits into from
Jun 12, 2023

Conversation

marcwitasee
Copy link
Contributor

@marcwitasee marcwitasee commented May 24, 2023 •
edited by jesteria
Loading

See #23.

@marcwitasee marcwitasee marked this pull request as ready for review June 1, 2023 16:34
@marcwitasee marcwitasee requested a review from jesteria June 1, 2023 16:34
@jesteria
Copy link
Member

jesteria commented Jun 8, 2023

FYI: Rebased changesets:

  • on top of (to bring in) changes made to main
  • stripped superfluous addition of ndt7 executable to pyproject.toml (it was already there)
  • updated readme.adoc wrt above

jesteria
jesteria reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@jesteria jesteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work! I'm going to play around with it in more depth shortly….

src/netrics/measurement/ndt7.py Outdated Show resolved Hide resolved
@jesteria
speed-ndt7: completed & polished measurement using NDT7 client
634d3e6 
* implemented timeout
* fixed output parsing
* etc.

see #23
@jesteria
speed-ndt7: added measurement to default configuration
0a46f0b 
The NDT7 test is made the model for speed test configuration (by the
alphabet and as it requires no additional paramters).

speed-ookla is intended to have the same configuration, with additional
parameters -- and so YAML anchor/alias is used.

Fate is upgraded to receive a bug-fix fully supporting this YAML
feature.

See #23
@jesteria jesteria merged commit 880d7ea into main Jun 12, 2023
@jesteria jesteria deleted the mr/ndt7-measurement branch June 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesteria jesteria jesteria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcwitasee @jesteria