Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add S to focus search input on /explore #402

Merged
merged 2 commits into from
Sep 9, 2019
Merged

add S to focus search input on /explore #402

merged 2 commits into from
Sep 9, 2019

Conversation

4www
Copy link
Contributor

@4www 4www commented Sep 4, 2019 •
edited
Loading

fixes #212

docs moved: https://github.com/briarsweetbriar/ember-keyboard

  • the mixin can't be used in the controller

@oskarrough
Copy link
Member

hm, didn't test but maybe you can try moving it to the component where the <input> exists?

@4www 4www requested a review from oskarrough September 7, 2019 10:19
@4www 4www changed the title WIP try to add S to focus search input on /explore add S to focus search input on /explore Sep 7, 2019
@oskarrough
Copy link
Member

Smart! Merge away

@4www 4www merged commit cd8835c into master Sep 9, 2019
@4www 4www deleted the feat/explore-search-keyboard branch September 9, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarrough oskarrough Awaiting requested review from oskarrough

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shortcut to focus search
2 participants
@4www @oskarrough