Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New setting maxEvents to limit number of log events added for later processing #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

huksley
Copy link

@huksley huksley commented Dec 12, 2017

Limits memory affected by issue #44

@arunmohapatra
Copy link

Need to add support of tomcat juli log back

@huksley
Copy link
Author

huksley commented Aug 6, 2018

@arunmohapatra can you elaborate? is there anything I should do?

@PeterFokkinga
Copy link

@huksley I believe Arunmohapatra refers to his issue #54 that has nothing to do (for I can see) with your PR.

But I think you still need to assign @abatkin as a reviewer if you want to have him include your code for the next release? (my hosting provider would be very happy if could set maxEvents!)

@almson
Copy link

almson commented Mar 10, 2020

I suspect (but haven't confirmed) a performance problem: deleting the first element of a big ArrayList is an expensive operation. Either change list type to LinkedList or drop new events instead of old ones.

cgoIT added a commit to cgoIT/logback-elasticsearch-appender that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants