Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds checking for downgrade redirects, storing of redirect domain and howing redirect domain in direct tests #1542

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WKobes
Copy link
Collaborator

@WKobes WKobes commented Nov 8, 2024

Fixes #270
Fixes #1521

This PR basically adds three functionalies:

I decided to store the redirection domain in the report since this way the report result remains static and allows us to represent the invalid redirect in the report. Old report pages will show the redirection domain in the direct tests view for as long as this domain is testable.

Todo's

Questions/to check:

  • Does storing redirect domain have any implications for e.g. privacy?
  • Passing stored redirect domain as in interface/views/domain.py#L120 feels a bit fishy, can it be done better?
  • Possible a broken HTTP server sending multiple Location headers could break stuff
  • Currently does not check if response code is 30x, should we do this?
  • Will using a formatted string like checks/categories.py#L946 work in translation files?

@WKobes WKobes marked this pull request as draft November 8, 2024 12:57
@bwbroersma
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants