Skip to content

Commit

Permalink
fix: removed unnecesary jest.resetmodules() in test cases to prevent …
Browse files Browse the repository at this point in the history
…sequelize from failing
  • Loading branch information
apsantiso committed Dec 28, 2023
1 parent b60afe2 commit 5ddc88e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
6 changes: 0 additions & 6 deletions src/modules/folder/folder.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,8 @@ describe('Folder module', () => {
let userTestRerpository: UserTestRepository;

beforeAll(async () => {
jest.resetModules();

folderTestRepository = new FolderTestRepository(sequelizeTest);
userTestRerpository = new UserTestRepository(sequelizeTest);

await sequelizeTest.authenticate();
await sequelizeTest.sync();
user = await userTestRerpository.getPrincipalUser();
userToken = userTestRerpository.generateToken(user, getEnv().secrets.jwt);

Expand Down Expand Up @@ -211,7 +206,6 @@ describe('Folder module', () => {
});

describe('Delete /folders - Delete Folders', () => {
// TODO: fix this test in the pipeline, in local it runs fine
it.skip('should delete all orphan folders', async () => {
const uuid = v4();

Expand Down
3 changes: 1 addition & 2 deletions src/modules/folder/folder.repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,7 @@ export class SequelizeFolderRepository implements FolderRepository {
[Op.not]: null,
},
},
// Sequelize throws an unknown error on e2e tests additionlOrders is passed here.
order: process.env.NODE_ENV === 'test' ? null : additionalOrders,
order: additionalOrders,
limit,
offset,
});
Expand Down

0 comments on commit 5ddc88e

Please sign in to comment.