Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_]: fix/e2e tests pipeline #248

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[_]: fix/e2e tests pipeline #248

wants to merge 12 commits into from

Conversation

apsantiso
Copy link
Collaborator

@apsantiso apsantiso commented Dec 19, 2023

This pull requests is just for separating the previous PR made by Edison.

It also intends to fix the production build problem that was showing when e2e tests are fixed.

How to test build for production:

  1. Clone your .env.development and change its name to .env (to simulate production .env file)
  2. Run docker run --rm -it $(docker build -q .) in the root folder of the project.
  3. Database connection is going to fail but the container should start without any extra error.

@apsantiso apsantiso changed the title Fix/e2e tests isolated Fix/e2e tests isolated (WIP) Dec 19, 2023
@sg-gs sg-gs marked this pull request as draft December 21, 2023 13:26
@sg-gs sg-gs changed the title Fix/e2e tests isolated (WIP) [_]: fix/e2e tests isolated Dec 21, 2023
@sg-gs
Copy link
Member

sg-gs commented Dec 21, 2023

If it is a WIP @apsantiso, keep the PR as a Draft, once ready, change the status to Ready for Review

@apsantiso apsantiso marked this pull request as ready for review January 2, 2024 13:48
@apsantiso apsantiso requested a review from sg-gs January 2, 2024 14:00
@apsantiso apsantiso added the bug Something isn't working label Jan 2, 2024
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@apsantiso apsantiso changed the title [_]: fix/e2e tests isolated [_]: fix/e2e tests pipeline Jan 3, 2024
@sg-gs sg-gs added the stalled label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants