Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-2354] feat: fixed space storage per user in workspaces #362

Merged

Conversation

apsantiso
Copy link
Collaborator

@apsantiso apsantiso commented Jul 16, 2024

This PR changes the way we handle the storage in workspaces. Previously, the owner was able to set a dynamic space, now, the space is fixed according to the parameters (maxSpace and numberOfSeats) received from payments.

The dynamic space is an incoming feature, so I just commented out some parts not to lose the logic was used there.

@apsantiso apsantiso changed the title feat: space limit is now fixed [PB-2354] feat: fixed space storage per user in workspaces Jul 16, 2024
@apsantiso apsantiso force-pushed the feat/workspaces-change-dynamic-space-to-fixed-storage branch from 840c7d1 to 4b2c5f0 Compare July 17, 2024 02:10
@apsantiso apsantiso marked this pull request as ready for review July 17, 2024 02:10
@apsantiso apsantiso self-assigned this Jul 17, 2024
@apsantiso apsantiso requested a review from sg-gs July 17, 2024 02:14
sg-gs
sg-gs previously approved these changes Jul 17, 2024
@sg-gs
Copy link
Member

sg-gs commented Jul 17, 2024

Migration run @apsantiso

$ NODE_ENV=production sequelize db:migrate

Sequelize CLI [Node: 20.12.2, CLI: 6.6.2, ORM: 6.35.0]

Loaded configuration file "src/config/sequelize.js".
Using environment "production".
== 20240716131219-add-number-of-seats-to-workspaces-table: migrating =======
== 20240716131219-add-number-of-seats-to-workspaces-table: migrated (0.365s)

✨  Done in 4.92s.

Copy link

sonarcloud bot commented Jul 17, 2024

@apsantiso apsantiso merged commit 5774568 into master Jul 17, 2024
10 of 11 checks passed
@apsantiso apsantiso deleted the feat/workspaces-change-dynamic-space-to-fixed-storage branch July 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants