-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PB-2354] feat: fixed space storage per user in workspaces #362
Merged
apsantiso
merged 2 commits into
master
from
feat/workspaces-change-dynamic-space-to-fixed-storage
Jul 17, 2024
Merged
[PB-2354] feat: fixed space storage per user in workspaces #362
apsantiso
merged 2 commits into
master
from
feat/workspaces-change-dynamic-space-to-fixed-storage
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
changed the title
feat: space limit is now fixed
[PB-2354] feat: fixed space storage per user in workspaces
Jul 16, 2024
apsantiso
force-pushed
the
feat/workspaces-change-dynamic-space-to-fixed-storage
branch
from
July 17, 2024 02:10
840c7d1
to
4b2c5f0
Compare
sg-gs
previously approved these changes
Jul 17, 2024
apsantiso
force-pushed
the
feat/workspaces-change-dynamic-space-to-fixed-storage
branch
from
July 17, 2024 13:38
4b2c5f0
to
6585c69
Compare
sg-gs
approved these changes
Jul 17, 2024
Migration run @apsantiso
|
Quality Gate passedIssues Measures |
apsantiso
deleted the
feat/workspaces-change-dynamic-space-to-fixed-storage
branch
July 17, 2024 14:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we handle the storage in workspaces. Previously, the owner was able to set a dynamic space, now, the space is fixed according to the parameters (maxSpace and numberOfSeats) received from payments.
The dynamic space is an incoming feature, so I just commented out some parts not to lose the logic was used there.