Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-3009]: feat/creation modification times on folders #401

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented Sep 30, 2024

Added creationTime and modificationTime fields to the folders table. When creating a new folder it is allowed to set these parameters optionally.
Also when modifying a folder or file's name the respective modificationTime field gets updated.

apsantiso
apsantiso previously approved these changes Oct 1, 2024
Copy link
Collaborator

@apsantiso apsantiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just wait for the migrations to be added.

@sg-gs
Copy link
Member

sg-gs commented Oct 2, 2024

Migrations run @jzunigax2 @apsantiso. Ready to merge.

Copy link

sonarcloud bot commented Oct 2, 2024

@apsantiso
Copy link
Collaborator

@sg-gs @jzunigax2 Just made a small commit to remove duplicated migrations to prevent our locals from breaking.

@apsantiso apsantiso merged commit 9c20e59 into master Oct 2, 2024
10 of 11 checks passed
@apsantiso apsantiso deleted the feat/creation-modification-times-on-folders branch October 2, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants