-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[_] fix: added future iat to new tokens issued on password change #406
Conversation
b5beb4a
to
93cf7c9
Compare
src/middlewares/passsword.spec.ts
Dismissed
} from './passport'; | ||
|
||
describe('JWT Utility Functions', () => { | ||
const secret = 'test_secret'; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
jwt key
The hard-coded value "test_secret" is used as
jwt key
The hard-coded value "test_secret" is used as
jwt key
The hard-coded value "test_secret" is used as
jwt key
The hard-coded value "test_secret" is used as
jwt key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used in tests, dismissed this issue.
93cf7c9
to
3236f07
Compare
Quality Gate passedIssues Measures |
Token's IAT do not include milliseconds, so we create new tokens with an IAT 60 seconds ahead so they are valid when compared against
lastPasswordChangedAt
value.This is the same implementation we have on drive-server, I'm just migrating it.