Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB-2376]: feat/load Backups incrementally (pagination) #1284

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

[PB-2376]: feat/load Backups incrementally (pagination) #1284

wants to merge 27 commits into from

Conversation

masterprog-cmd
Copy link
Contributor

@masterprog-cmd masterprog-cmd commented Sep 20, 2024 •
edited
Loading

  • Incremental loading of backups to improve the UX (pagination) experience. Items are loaded 50 by 50.
  • Retrieve items after sharing an item to show the share icon (Drive view).

@masterprog-cmd masterprog-cmd added the enhancement New feature or request label Sep 20, 2024
@masterprog-cmd masterprog-cmd self-assigned this Sep 20, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 9:13am

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 20, 2024 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: aaf19f0
Status:⚡️  Build in progress...

View logs

@masterprog-cmd masterprog-cmd marked this pull request as draft September 20, 2024 09:41
@masterprog-cmd masterprog-cmd marked this pull request as ready for review September 20, 2024 10:27
@masterprog-cmd masterprog-cmd marked this pull request as draft September 20, 2024 10:34
@masterprog-cmd masterprog-cmd changed the title [PB-2376]: feat/load Backups incrementally on Drive Web (pagination) [PB-2376]: feat/load Backups incrementally (pagination) Sep 23, 2024
@CandelR CandelR marked this pull request as ready for review September 23, 2024 10:58
@CandelR
Merge pull request #1285 from internxt/fix/file-viewer-navigation-for…
565d8cc 
…-backups

[_]: fix/file viewer navigation for backups
CandelR
CandelR requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check sonar warnings

src/app/backups/hooks/useBackupsPagination.test.ts Outdated Show resolved Hide resolved
src/app/backups/hooks/useBackupsPagination.test.ts Outdated Show resolved Hide resolved
src/app/backups/hooks/useBackupsPagination.ts Outdated Show resolved Hide resolved
src/app/backups/views/BackupsView/BackupsView.tsx Outdated Show resolved Hide resolved
src/app/backups/views/BackupsView/BackupsView.tsx Outdated Show resolved Hide resolved
src/app/drive/components/FileViewer/FileViewerWrapper.tsx Outdated Show resolved Hide resolved
src/app/backups/hooks/useBackupsPagination.test.ts Outdated Show resolved Hide resolved
src/app/backups/hooks/useBackupsPagination.test.ts Outdated Show resolved Hide resolved
src/app/backups/hooks/useBackupsPagination.test.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CandelR CandelR CandelR approved these changes

Assignees

@masterprog-cmd masterprog-cmd

Labels
enhancement New feature or request ready-for-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterprog-cmd @CandelR