Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB-516]: feat/send private key encrypted to server wip #765

Draft
wants to merge 5 commits into
base: release/2.7.0
Choose a base branch
from
Draft

[PB-516]: feat/send private key encrypted to server wip #765

wants to merge 5 commits into from
+18 −16

Conversation

miguelsw
Copy link
Contributor

@miguelsw miguelsw commented Aug 1, 2023 •
edited by sg-gs
Loading

Details:

  • We need to send the private key to drive-server-wip instead of sending it to drive-server
  • The endpoint used is /password
    Updates:
  • Added new client methods in the factory to send the private key encrypted to drive-server-wip
  • Added field encryptVersion to the payload, the backend requires it

⚠️ One change in one method on the SDK is needed, link here:
internxt/sdk#159

@miguelsw miguelsw self-assigned this Aug 1, 2023
@vercel
Copy link

vercel bot commented Aug 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:31am

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@miguelsw miguelsw requested a review from CandelR August 1, 2023 19:00
@miguelsw miguelsw marked this pull request as ready for review August 1, 2023 23:46
@miguelsw miguelsw requested a review from CandelR August 3, 2023 14:00
@sg-gs sg-gs added the enhancement New feature or request label Aug 7, 2023
@CandelR CandelR changed the base branch from master to feature/PB-118-advanced-folder-sharing August 8, 2023 05:56
CandelR
CandelR approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiiting to merge SDK PR

Base automatically changed from feature/PB-118-advanced-folder-sharing to master September 21, 2023 15:20
@sg-gs
Copy link
Member

sg-gs commented Sep 13, 2024

What about this one @CandelR, is this still needed?

@CandelR
Copy link
Contributor

CandelR commented Sep 13, 2024

What about this one @CandelR, is this still needed?

@sg-gs If we want to migrate the endpoint from server to server-wip I understand that yes. I will talk to Andres about this to see what we do, as he can give me more context on whether it is necessary to migrate the enpoint or not

@CandelR CandelR changed the base branch from master to release/2.7.0 September 30, 2024 07:12
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: bcfacf4
Status:⚡️  Build in progress...

View logs

@CandelR CandelR self-requested a review October 2, 2024 09:46
@CandelR
Copy link
Contributor

CandelR commented Oct 2, 2024

Endpoint not working properly, blocked until new change password enpoint returns the new generated tokens.

@CandelR CandelR marked this pull request as draft October 2, 2024 09:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CandelR CandelR Awaiting requested review from CandelR CandelR is a code owner

Assignees

@miguelsw miguelsw

Labels
enhancement New feature or request ready-for-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsw @sg-gs @CandelR