Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[_]: feat/updating the name of the params and functions of payments #242

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[_]: feat/updating the name of the params and functions of payments #242

wants to merge 4 commits into from
+32 −14

Conversation

masterprog-cmd
Copy link
Contributor

@masterprog-cmd masterprog-cmd commented Sep 6, 2024 •
edited
Loading

Updating the names for better understanding:
Renamed functions:

  • createCustomer -> createOrGetCustomer

Parameters (from createSubscription function):

  • quantity -> seatsForBusinessSubscription

Other cahnges:

  • Use get instead of post to get the customer Id endpoint
  • Use post instead of get to get the client secret of the payment intent.

@masterprog-cmd masterprog-cmd added the enhancement New feature or request label Sep 6, 2024
@masterprog-cmd masterprog-cmd self-assigned this Sep 6, 2024
@masterprog-cmd masterprog-cmd mentioned this pull request Sep 6, 2024
Merged
@masterprog-cmd masterprog-cmd marked this pull request as ready for review September 9, 2024 06:50
@masterprog-cmd masterprog-cmd marked this pull request as draft September 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CandelR CandelR Awaiting requested review from CandelR

At least 1 approving review is required to merge this pull request.

Assignees

@masterprog-cmd masterprog-cmd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterprog-cmd @CandelR