Fix: Export All better handles missing items. #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, remove internal tracking (intersystems#821) - Allows "Export all" to proceed and complete correctly.
isc-pbarton
requested changes
Aug 6, 2025
| @@ -1720,7 +1721,11 @@ ClassMethod ExportItem(InternalName As %String, expand As %Boolean = 1, force As | |||
| write !, "Production decomposition enabled, skipping export of production class" | |||
| set filename = "" | |||
| } else { | |||
| $$$QuitOnError($system.OBJ.ExportUDL(InternalName, filename,"-d/diff")) | |||
| set tSC = $SYSTEM.OBJ.ExportUDL(InternalName, filename,"-d/diff") | |||
There was a problem hiding this comment.
There may be other errors from ExportUDL that we actually do want to fail on. I'd suggest a slight change:
if '##class(%RoutineMgr).Exists(InternalName) {
// do the clean up here
} else {
// call ExportUDL with ThrowOnError
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is good enough @isc-pbarton , but I'm open to changes if there are other things I didn't consider.