Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scd] deletion of entity ref. accepts any OVN for deletion. #1081

Closed
Shastick opened this issue Aug 28, 2024 · 0 comments · Fixed by #1083
Closed

[scd] deletion of entity ref. accepts any OVN for deletion. #1081

Shastick opened this issue Aug 28, 2024 · 0 comments · Fixed by #1083
Assignees
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority

Comments

@Shastick
Copy link
Contributor

Shastick commented Aug 28, 2024

Describe the bug
The implementation of the Operational Intent Reference (OIR) deletion endpoint ignores the provided OVN and will delete the OIR in any case.

The same issue seems to affect Constraint Reference (CR) deletion.

(Subscriptions, on the other hand, are correctly handled)

Expected behavior
The OIR deletion endpoint is expected to only delete the specified OIR if the passed OVN matches the one currently stored for that OIR.

If the OVNs don't match, we would expect a 409, as specified in the astm-utm protocol's OpenAPI spec, and the OIR should not be deleted.

The CR deletion endpoint should behave in the same way.

In addition to the fix itself, we would expect the uss_qualifier to detect when a DSS implementation does not validate OVNs. Enriching the qualifier with the relevant checks is covered by this issue.

Additional context
Originally described by @BenjaminPelletier in this issue

@Shastick Shastick changed the title [scd] deletion of operational intent ref. accepts any OVN for deletion. [scd] deletion of entity ref. accepts any OVN for deletion. Aug 28, 2024
@BenjaminPelletier BenjaminPelletier added P2 Normal priority bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations labels Aug 28, 2024
@Shastick Shastick self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Shastick @BenjaminPelletier and others