[scd] oir deletion now checks for OVN correctness #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
1081-ovn-validation-oirs
branch
from
aaa835c
to
e4be985
Compare
BenjaminPelletier
approved these changes
Aug 28, 2024
Shastick
force-pushed
the
1081-ovn-validation-oirs
branch
from
a90d4b5
to
7c5771e
Compare
7 tasks
Open
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing OVN check to the OIR deletion logic.
This is a first step towards fixing #1081 (it covers OIRs)
Test plan: a DSS version built from this PR passes the new qualifier scenario designed to detect this kind of issue.