[scd] oir upsert: factor out determination of subscriptions to notify #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
approved these changes
Aug 30, 2024
| @@ -508,6 +508,56 @@ func validateUpsertRequestAgainstPreviousOIR( | |||
| return nil | |||
| } | |||
|
|
|||
| func incrementIndicesAndGetRelevantSubscriptions( | |||
There was a problem hiding this comment.
nit: I think the primary thing this function is doing is getting relevant subscriptions, with a sub-behavior of incrementing notification indices
Suggested change
| func incrementIndicesAndGetRelevantSubscriptions( | |
| func getRelevantSubscriptionsAndIncrementIndices( |
Shastick
force-pushed
the
oir-upsert-refactor-1c-extract-notification
branch
from
c4bdf24
to
47e45c3
Compare
mickmis
reviewed
Sep 2, 2024
| @@ -517,6 +517,56 @@ func validateUpsertRequestAgainstPreviousOIR( | |||
| return nil | |||
| } | |||
|
|
|||
| func getRelevantSubscriptionsAndIncrementIndices( | |||
There was a problem hiding this comment.
Drive-by comment: also use this in DeleteOperationalIntentReference? There seems to be some common logic (although maybe there are some small deviations)
There was a problem hiding this comment.
Good point. I'll quickly check: if the method can be used as-is I'll update to use it, otherwise I'll keep that for another day
There was a problem hiding this comment.
Ended up doing it as it was an easy fix.
Shastick
force-pushed
the
oir-upsert-refactor-1c-extract-notification
branch
from
8228781
to
8eed218
Compare
Shastick
force-pushed
the
oir-upsert-refactor-1c-extract-notification
branch
from
8eed218
to
46d34f0
Compare
mickmis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #1088