[terraform/utils] Lint terraform variables generation #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ethangraham2001
changed the title
barroco
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Hi @ethangraham2001 , thank you for this PR. Please find small comments inline.
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--diff", action="store_true") |
There was a problem hiding this comment.
Please add an argument help="..." and describe the action and make sure the exit code is mentionned.
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--diff", action="store_true") |
There was a problem hiding this comment.
Please add an argument help="..." and describe the action and make sure the exit code is mentionned.
barroco
changed the title
|
Could you please add this command to Makefile target: |
ethangraham2001
commented
Sep 6, 2024
ethangraham2001
commented
Sep 9, 2024
barroco
reviewed
Sep 9, 2024
ethangraham2001
changed the title
`variables.py` file to be run outside of the docker container, and copied over the necessary file needed for running the `--lint` flag.
barroco
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lint stage for checking that locally-stored
.gen.tffiles are the same as the generated output of callingvariables.py. This is done by adding a new--lintflag tovariables.pythat checks for differences between the generated output the local files without writing anything out to disk -variables.py --lintwill exit with status code 0 on success, and 1 on failure. Theterraform-lintsection of the top-level makefile is updated to call this accordingly.This is intended to be used as a CI check.
Relates to issue #1084