[yugabyte] Yugabyte compatible implementation #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
force-pushed
the
yugabyte-implementation
branch
5 times, most recently
from
968bb04 to
ea1debf
Compare
barroco
force-pushed
the
yugabyte-implementation
branch
from
fe834e0 to
e735f9a
Compare
barroco
force-pushed
the
yugabyte-implementation
branch
2 times, most recently
from
f07f19c to
38dd892
Compare
barroco
force-pushed
the
yugabyte-implementation
branch
from
4ddbfb2 to
29fc46a
Compare
barroco
force-pushed
the
yugabyte-implementation
branch
from
29fc46a to
6e5a1d0
Compare
barroco
force-pushed
the
yugabyte-implementation
branch
from
6e5a1d0 to
ed79acc
Compare
mickmis
reviewed
Jan 30, 2025
| dlv --headless --listen=:4000 --api-version=2 --accept-multiclient exec --continue /usr/bin/core-service -- \ | ||
| -cockroach_host local-dss-crdb \ | ||
| # Linter is disabled to properly unwrap $DATASTORE_CONNECTION. | ||
| # shellcheck disable=SC2086 |
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice, thanks for the link. Let's address it in a subsequent PR due to its possible complexity.
barroco
force-pushed
the
yugabyte-implementation
branch
from
a55a179 to
ddd69f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to run core-service with a yugabyte datastore.
Key changes:
Note that it was identified that the current implementation may show some failing test runs of the prober with Yugabyte. Current assumption is that the problem is due to default transaction isolation which is not the same in CRDB (Serializable) and Yugabyte (Snapshot). The later may lead to serialization anomalies for single statement queries. Adapting the code to support this specific use case with Yugabyte may require extensive refactoring which may better be addressed in a separate PR.
Prober tests are catching this issue unreliably. It has been kept disabled for Yugabyte until the implementation is stable.
Commits have been organised in order to facilitate the review.