Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] only install ARM-specific dependencies on an ARM architecture #773

Merged

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Sep 6, 2024

In the spirit of not installing things where they are not required, this PR adds a check for the local architecture and only installs the arm-specific dependencies when indeed needed.

Notes:

  • explicitly add make to the first package install: it is required by jsonnet and probably included implicity via the ARM dependencies
  • we need to install additional tools for ARM because the base image will behave slightly differently depending on the architecture when the requirements are pip install'ed, probably because some dependencies have differing installation procedures depending on the architecture.
  • x86 should be seen as the default architecture we target (that's what is available in CI), and we add what is missing for arm in order to make developer's and users life easier

@Shastick Shastick force-pushed the install-arm-deps-only-for-arm branch 3 times, most recently from b8695fc to 0e848ff Compare September 6, 2024 11:55
@Shastick
Copy link
Contributor Author

Shastick commented Sep 6, 2024

Note: the last failure affected two seemingly random configurations with 502's from official docker registries

 rid_bootstrapper Error Head "https://registry-1.docker.io/v2/interuss/dss/manifests/v0.17.0": received unexpected HTTP status: 502 Bad Gateway
 crdb Error context canceled
 scd_bootstrapper Error context canceled
Error response from daemon: Head "https://registry-1.docker.io/v2/interuss/dss/manifests/v0.17.0": received unexpected HTTP status: 502 Bad Gateway

This might be a random fluke or the sign that we're hitting some limits somewhere.

@Shastick Shastick force-pushed the install-arm-deps-only-for-arm branch from 0e848ff to a1bc075 Compare September 6, 2024 12:14
@Shastick Shastick marked this pull request as ready for review September 6, 2024 13:32
@BenjaminPelletier BenjaminPelletier merged commit ebd59ce into interuss:main Sep 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants