[ci] add setuptools installation and pinning to the Dockerfile #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
separate-setuptools-install
branch
4 times, most recently
from
1183143
to
00a9fb4
Compare
BenjaminPelletier
approved these changes
Sep 11, 2024
|
nit: Could you change the title and description of the PR to clarify that we're just moving setuptools out of requirements.txt and installing it separately? Importantly, it seems like setuptools is still pinned (to 74.1.2 per line 23), so it's not accurate to say it is "unpinned". I think that's important because I think the root cause of one of our recent issues is that not enough things were pinned, and I don't think we've had any problems due to something being pinned (so, I would expect us to almost always only move toward more pinning and not less pinning). |
Shastick
force-pushed
the
separate-setuptools-install
branch
from
00a9fb4
to
c87e081
Compare
Shastick
changed the title
Shastick
changed the title
punamverma
pushed a commit
to nasa/monitoring
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #771 to solve #768: it involves installing setuptools and pinning its version directly in the Dockerfile, before the actual requirements get installed.
Background
Since
python:3.12.5-slim,setuptoolsis not pre-installed anymore, causing our builds to fail when using this (or later) images.See this comment for some background and details about the considered options, and why we did not choose to add setuptools to
requirements.in.This PR also sets the base image to
python:3.12.6-slimto show that the Dockerfile can be built.