Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier/scenarios/data_exchange_validation] Fix wrong check failure for lack of notification #800

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

mickmis
Copy link
Contributor

@mickmis mickmis commented Oct 4, 2024

This addresses #797.
We keep track of the operational intent IDs that were created during the scenario run in order to ignore notifications about them that might have been sent asynchronously after the rejected planning attempt.
This also enhances the failure message of the check and add a low severity check for parsing the interaction query request.

@mickmis mickmis marked this pull request as ready for review October 4, 2024 18:20
Copy link
Contributor

@punamverma punamverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickmis Thanks for the fix. The changes look good to me. It would help solve the issue caused by async notification from the first test case being picked up by the next test case in the scenario.

Not for any action in this PR, but just as a discussion. Do you think it would be helpful to have a test that checks if a tested_uss sent a notification to the relevant USSes, about its ended operation? Would it cover any of the ASTM F3548 requirements?

@mickmis
Copy link
Contributor Author

mickmis commented Oct 14, 2024

Not for any action in this PR, but just as a discussion. Do you think it would be helpful to have a test that checks if a tested_uss sent a notification to the relevant USSes, about its ended operation? Would it cover any of the ASTM F3548 requirements?

This could fall under SCD0090 depending on the interpretation of 'a managing USS [...] modifies an operational intent'.
Whether that interpretation is correct and whether such a test would be helpful are questions good to ask during the InterUSS weekly.

@mickmis mickmis merged commit 2ca7dee into interuss:main Oct 14, 2024
20 checks passed
@mickmis mickmis deleted the fix-797 branch October 14, 2024 12:02
github-actions bot added a commit that referenced this pull request Oct 14, 2024
punamverma pushed a commit to nasa/monitoring that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants