Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add upload/download icon in upload/download stat + allow hiding header row #30

Merged
merged 7 commits into from
Jun 24, 2024
Merged

feat: add upload/download icon in upload/download stat + allow hiding header row #30

merged 7 commits into from
Jun 24, 2024

Conversation

aidanaden
Copy link
Contributor

Features added:

  • adds upload/download icons to upload/download values
  • hide_headers config attribute to allow for hiding header row in torrent tab (Name, Completion, Download, Upload, etc)

Purpose is to allow for complete minimalism for pro users (me) that are already familiar with usual torrent statistic values

@aidanaden aidanaden self-assigned this Jun 23, 2024
@aidanaden aidanaden requested a review from micielski June 23, 2024 01:48
micielski
micielski requested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@micielski micielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If hide_header option is in the [general] table in toml, and not in something like [torrents_tab], can you make it apply to search tab also?

rm-main/src/ui/tabs/torrents/rustmission_torrent.rs Outdated Show resolved Hide resolved
rm-main/src/ui/tabs/torrents/mod.rs Outdated Show resolved Hide resolved
@micielski micielski added the enhancement New feature or request label Jun 23, 2024
@aidanaden aidanaden requested a review from micielski June 23, 2024 10:31
@aidanaden aidanaden added the done This issue or pull request has been completed label Jun 23, 2024
@micielski
Copy link
Contributor

Could you change the config option name from hide_headers to headers_hide?

@aidanaden aidanaden requested review from micielski and removed request for micielski June 24, 2024 09:35
micielski
micielski requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@micielski micielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
There's a missing B
Fix tthis

@aidanaden
Copy link
Contributor Author

image There's a missing B Fix tthis

is this the torrent upload speed? or the overall upload speed bottom stat?

@aidanaden aidanaden requested a review from micielski June 24, 2024 17:12
@micielski micielski merged commit a3eceda into intuis:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micielski micielski Awaiting requested review from micielski

Assignees

@aidanaden aidanaden

Labels
done This issue or pull request has been completed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidanaden @micielski