Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: torrent status icons #38

Closed

Conversation

aidanaden
Copy link
Contributor

No description provided.

@aidanaden aidanaden self-assigned this Jun 24, 2024
@aidanaden aidanaden added the done This issue or pull request has been completed label Jun 24, 2024
@aidanaden aidanaden requested a review from micielski June 24, 2024 01:08
Copy link
Contributor

@micielski micielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it breaks auto_hide = true.
Correct me if I'm wrong

@aidanaden
Copy link
Contributor Author

I think it breaks auto_hide = true. Correct me if I'm wrong

tested it locally but doesnt seem to have any issues? u can test it out just in case because i dont have too many torrents on transmission right now

@micielski
Copy link
Contributor

I mean, I have now this one column filled with these ticks:
image
Maybe a better solution would be to add a new column for displaying current status of a torrent which would be at the beginning and one nerd font icon long. For example nf-fa-pause when a torrent is paused

@aidanaden
Copy link
Contributor Author

aidanaden commented Jun 24, 2024

@micielski

oh sure ya having a status column on the left of the name would be nice:

  • downloading would be a "►" icon
  • paused would be a pause icon
  • completed would be a "✓" icon

looks good?

@micielski
Copy link
Contributor

* downloading would be a "►" icon

For downloading maybe use the same icon as for download speed

@aidanaden
Copy link
Contributor Author

For downloading maybe use the same icon as for download speed

it'd feel a bit inconsistent since we're already using pause icon no?

@micielski
Copy link
Contributor

For downloading maybe use the same icon as for download speed

it'd feel a bit inconsistent since we're already using pause icon no?

How would you represent seeding then?

@aidanaden
Copy link
Contributor Author

How would you represent seeding then?

Screenshot 2024-06-24 at 11 44 05 PM

we could use qbittorrent's icons as reference?

@micielski
Copy link
Contributor

we could use qbittorrent's icons as reference?

Sure

@aidanaden aidanaden requested a review from micielski June 24, 2024 17:05
@aidanaden aidanaden changed the title feat: tick icon for completed torrents feat: torrent status icons Jun 24, 2024
@micielski
Copy link
Contributor

It still doesn't look good with many torrents:
image
Everything blends in, it's hard to differentiate which torrents are actually being downloaded and which ones are actually uploading something.

@aidanaden
Copy link
Contributor Author

aidanaden commented Jun 24, 2024

Screenshot 2024-06-25 at 3 02 42 AM

@micielski added colors for the status icons to allow for easier differentiation (i don't know what else i can do to make it easier to differentiate between torrents tbh)

should i also set the download icon in the "download speed" column to be green as well ? since it's currently green in the status column

@micielski micielski added this to the 0.4 milestone Jun 27, 2024
@micielski micielski added the enhancement New feature or request label Jun 27, 2024
@aidanaden aidanaden changed the base branch from main to v0.4 June 30, 2024 10:09
@aidanaden aidanaden mentioned this pull request Jun 30, 2024
@aidanaden aidanaden changed the base branch from v0.4 to main July 4, 2024 08:36
@micielski micielski removed the done This issue or pull request has been completed label Jul 5, 2024
@aidanaden aidanaden closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants