Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#128 - Adding intuit_tid to FMSException & utilizing in code while th… #153

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mani-sreekakula
Copy link

…rowing

@coveralls
Copy link

coveralls commented Oct 18, 2020

Coverage Status

Coverage decreased (-0.3%) to 66.204% when pulling 053d0b0 on mani-sreekakula:develop into 66a2b40 on intuit:develop.

Copy link

@rpudota rpudota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mani-sreekakula Thanks for making these changes.
I did a quick test and it looks like intuit_tid is not being passed from HttpResponse to ResponseElements. As a result the interceptor classes get a null value when reading the intuit_tid header from ResponseElements.

To fix this you will need to read intuit_tid header from HttpResponse and add it as a header in ResponseElements here in HTTPClientConnectionInterceptor.setResponseElements method -

private void setResponseElements(IntuitMessage intuitMessage, HttpResponse httpResponse) throws FMSException {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants