Fix auth api issue - #131967 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: api-keys can get passed through get requests, which is risky. It defaults to the authorization header anyways if not present (and YaYata doesn't send it out through the url anyways it seems) so not urgent, but better to remove it in my opinion.
This is inherited from the "Experimental read-only API key authentication" commit. Which didn't include the default to auth header if key not present in url.
d484c9f
Proposed solution: remove the possibility to send keys through the url, even if it's not used -- better to completely remove the possibility.