Rename first
-> lowerbound
, last
-> upperbound
#198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to stop overloading
first
andlast
fromBase
, as per #90, since it is very pun-like.I've tried to strike a balance that makes this minimally disruptive to users of the package, while also making the internal vocabulary used by the package not confusing.
I've renamed these two types
LeftEndpoint
->LowerEndpoint
RightEndpoint
->UpperEndpoint
Leaving the old names as aliases to avoid breaking old code.
I've also renamed the
Direction
types toLower
andUpper
.Finally, I've marked this as 2.0 and removed any old deprecations, and added in new ones for
first
andlast
as well as the constructors forLeftEndpoint
andRightEndpoint
.I think this this would be an improvement in nomenclature, but even with my efforts to avoid disruption, it will still invovle churn.
What do folks think? Is this worth it?