Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZones <= 1.5 for testing #117

Merged
merged 1 commit into from
Nov 24, 2021
Merged

TimeZones <= 1.5 for testing #117

merged 1 commit into from
Nov 24, 2021

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Nov 23, 2021

A temporary solution to restrict our test TimeZones.jl release to <= 1.5. Eventually, we should:

  1. Update our specimen files
  2. Migrate our tests to load JLSO files in a separate process/environment and pass specific tests/checks to those activated environments
  • We should probably also define a more explicit upgrade workflow that uses this approach as well

Closes #115

A temporary solution to restrict our test TimeZones.jl release to <= 1.5. Eventually, we should:

1. Update our specimen files
2. Migrate our tests to load JLSO files in a separate process/environment and pass specific tests/checks to those activated environments
  - We should probably also define a more explicit upgrade workflow that uses this approach as well
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #117 (86dbe21) into master (04b83b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files           6        6           
  Lines         215      215           
=======================================
  Hits          210      210           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b83b3...86dbe21. Read the comment docs.

@rofinn rofinn merged commit ada8158 into master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TypeError: in new, expected Union{Nothing, DateTime}, got a value of type Int64
2 participants