Skip to content

Commit

Permalink
Merge pull request #559 from karolina-siemieniuk-morawska/fix_undefin…
Browse files Browse the repository at this point in the history
…ed_key

fix undefined property error
  • Loading branch information
karolina-siemieniuk-morawska authored Jan 25, 2024
2 parents 88cf65c + 5e8b4ea commit a10776b
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions src/shared/services/compare-keys-by-schema.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,21 @@ export class CompareKeysBySchemaService {
*/
compare(key1: string, key2: string, schema: JSONSchema): number {
// Sort by priority, larger is the first.
const priorty1 = schema.properties[key1].priority || 0;
const priority2 = schema.properties[key2].priority || 0;
const priority1 =
(schema &&
schema.properties &&
schema.properties[key1] &&
schema.properties[key1].priority) ||
0;
const priority2 =
(schema &&
schema.properties &&
schema.properties[key2] &&
schema.properties[key2].priority) ||
0;

if (priorty1 > priority2) { return -1; }
if (priorty1 < priority2) { return 1; }
if (priority1 > priority2) { return -1; }
if (priority1 < priority2) { return 1; }

// Sort alphabetically.
if (key1 < key2) { return -1; }
Expand Down

0 comments on commit a10776b

Please sign in to comment.