-
Notifications
You must be signed in to change notification settings - Fork 70
reorg docs operate #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
reorg docs operate #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these great changes! I think the reorg overall makes sense. I mostly added comments on introducing the environment variables, and whether that should be included earlier in the flow.
@@ -1,4 +1,4 @@ | |||
# Configuration | |||
# Configure everything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the section order...I think this should be before "Customize metadata model". Settings like TRUSTED_HOSTS are going to be needed by everyone who is standing up an instance, while only some people will need to get into metadata.
This could also get broken up into more common and less common configuration elements...but probably not needed for the initial reorg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "common and less common configuration elements" is indeed the right strategy to address that one. We could highlight the common/needed configuration elements in either the upcoming "Get Started" section and/or the Operate/ops/deploy.md
section (once the Get Started section is done).
This "Configure everything" section is a bit of a catch-all-else section for all the knobs and levers InvenioRDM provides that were not covered yet. Since it is so big and will grow, pushing it towards the end of the Operate section feels like the right place: it's a reference section of everything configuration. More important configurations like TRUSTED_HOSTS
and so on, have to be highlighted/linked to from elsewhere to make sure they get the right attention though as you've pointed out.
New Ticket: #768
@@ -1,13 +1,13 @@ | |||
# Records custom fields | |||
# Add field(s) to records |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use "custom field(s)" instead of "field(s)". Since they aren't treated like other fields.
- [Log](./ops/logging.md) | ||
- [Back up search indices](./ops/backup_search_indices.md) | ||
- [Redirect legacy routes](./ops/route_migration.md) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd lean toward putting configure here, or even before deployment. The beginning part with environment variables is really needed before folks start moving toward deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, having a section for the subset of configurations really needed before deployment would make sense here. As mentioned above, I will loop back around to this one when the Getting Started section is done to see how the difference splits. I am saying this because some of those configuration used to be in the install section, so I wonder how they will sit when that section gets transformed 🤔 .
e73c7b6
to
0059adc
Compare
Updated. I will do a content pass to highlight the needed configurations as part of #768 . |
and demosite deployed: https://fenekku.github.io/docs-invenio-rdm/ |
fda039a
to
488d995
Compare
Reorganize the Customize, Develop and Deploy sections into Operate section (and other sections).
Notes
This reorganization pass is probably more dramatic than the previous ones.
imgs
and placed closest to image usage in Operate (not really touched image folder of other sections)Review divisions
Those are artificial savepoints to help with the review. Will squash all of them when merging.
Screenshots
Home page

Operate section

Demosite
Demosite (all reorg so far): https://fenekku.github.io/docs-invenio-rdm/
Up next
Reorganize the "Install" section into "Getting Started"