isbn: fix cases where masking fails #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fallbacks to a canonical ISBN value in case the hyphenation/masking fails.
* Bumps the minor version, to allow keeping 1.1.x as a Python 2 compatible version.
|
Coordination: Placed in "Work in progress" because there is a rebase to be done and versioning to adjust. But it looks good to me! Once that's done, we can have another review or skip to merge as you wish @slint . |
fenekku
approved these changes
Mar 14, 2023
|
Coordination: bumpety bump |
|
I think here it's less a review than a conflict resolution rebase that is missing. Since that's usually better done by the original PR submitter, I would leave it as work in progress. If someone other than @slint has time and feels confident they can resolve the conflict that could be done too. Let's say we circle back around to this in 1 week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails.