cli: add command for domain create #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
commented
Jun 27, 2024
| def domains_create(domain): | ||
| """Create domain.""" | ||
| try: | ||
| domain_category = DomainCategory.create(domain.lower()) |
There was a problem hiding this comment.
question: is the lower really necessary? should it be like that?
There was a problem hiding this comment.
The column is actually named label so I would imagine it's the human-friendly name. IMHO it shouldn't have to be lowercase, but it also doesn't matter since the FK is an integer
slint
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.