revert: commit f9a8a85 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it introduced circular dependency with invenio-users-resources. the feature will be moved to another package.
zzacharo
reviewed
Aug 8, 2024
| @@ -44,7 +44,7 @@ fi | |||
| python -m check_manifest | |||
| python -m setup extract_messages --output-file /dev/null | |||
| python -m sphinx.cmd.build -qnN docs docs/_build/html | |||
| eval "$(docker-services-cli up --db ${DB:-postgresql} --search ${SEARCH:-opensearch} --cache ${CACHE:-redis} --env)" | |||
There was a problem hiding this comment.
this should stay no? Otherwise, we cannot test search no?
There was a problem hiding this comment.
it was an addition of the commit i will revert. i thought to remove all what was added in the utnapischtim@f9a8a85
There was a problem hiding this comment.
I think we can keep that... Basically instead of git revert <commit> you can just push a new one with only removing the necessary parts
There was a problem hiding this comment.
if we add that to the tests then a container will be started which is not used. that consumes resources which are unnecessary
since it was not there before in my opinion we should save resources
utnapischtim
force-pushed
the
remove-introduced-cli-groups
branch
2 times, most recently
from
f6d4d46
to
61423c6
Compare
utnapischtim
force-pushed
the
remove-introduced-cli-groups
branch
from
61423c6
to
1ef9f7c
Compare
zzacharo
approved these changes
Aug 8, 2024
kpsherva
approved these changes
Aug 8, 2024
|
which version do we need to yank? |
5.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature will be moved to another package.