UI: fix spacing on password reset form

[carlinmack]

❤️ Thank you for your contribution!

Close #496

Description

Please describe briefly your pull request.

Before and after

Before and after

Once this is merged I'll remove the reset-password rule as it will no longer be used

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[alejandromumo]

CI seems broken 🥶 can you have a look?

[jrcastro2]

LGTU! Just the comment about wtforms, we should check all the other invenio deps to ensure that we don't need to pin it there. If you already did just omit the comment.

[jrcastro2]

Major: Do we know which dependency is bringing wtforms? we are afraid that it might come from another dependency and we should fix it there instead of pinning it here.

[utnapischtim]

wtforms is at least in invenio-oauth2server and i plan to unpin it there to prepare the code to migrate to flask>=3.0. would it be possible to fix it and not pin it?

[carlinmack]

I was planning to pin in invenio-admin instead but if there is a way to fix that would be better :) I personally am not sure how to fix the issue (besides setting the _form_error_key parameter of the form to None)

[utnapischtim]

if you plan to pin it in invenio-admin i am totally fine with it, because there is the plan (and PR's open) to remove the support of invenio-admin from invenio-app-rdm.

where do we would have to fix that problem? in invenio-admin or in flask-admin?

[jrcastro2]

Comment: As you stated in the description we can remove the rule reset-password rule from invenio-theme. We would recommend doing it now, otherwise we tend to forget 😉

[carlinmack]

CI should be fixed when inveniosoftware/invenio-admin#106 is merged

After this is merged, we should merge this to remove the unnecessary CSS inveniosoftware/invenio-theme#401