Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: FAIR signposting level 1 support (link rel item) #2944

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptamarit
Copy link
Member

❤️ Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@@ -28,6 +28,7 @@
<meta name="citation_pdf_url" content="{{ file_url }}"/>
{%- endif %}
<link rel="alternate" type="{{ file.mimetype }}" href="{{ file_url }}">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we do not use the alternate type in the right way. According to MDN's documentation, it's meant to "indicates that the referenced document is an alternative format (such as a PDF)", but in our case files are other documents than the landing page.

We could remove this line, but on the other hand, people might be relying on it already.

@ptamarit ptamarit force-pushed the 2937-fair-signposting-level-1-link-rel-item branch from 3a846b2 to 63f22cc Compare December 16, 2024 10:58
@ptamarit ptamarit marked this pull request as draft January 7, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAIR signposting level 1 support (HTTP Link headers & link rel item)
1 participant