Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: remove unnecessary <p> tag #2946

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Dec 16, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Error 26 is because we wrap the description in a <p> tag, but the paragraph tag can't contain HTML like lists or paragraphs. The HTML of the page is

<section id="description" class="rel-mt-2 rich-input-content" aria-label="Record description">
    <h2 id="description-heading" class="sr-only">Description</h2>

    <div style="word-wrap: break-word;">
        <p>
        <ul>
            <li>One list item</li>
        </ul>
        </p>
    </div>
</section>

With paragraphs we still get Error 26
with similar html

<section id="description" class="rel-mt-2 rich-input-content" aria-label="Record description">
    <h2 id="description-heading" class="sr-only">Description</h2>

    <div style="word-wrap: break-word;">
        <p>
        <p>No list</p>
        </p>
    </div>
</section>

and when there is no description the section does not appear in the html
image
image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack changed the title Carlin patch 2 bug: remove unnecessary <p> tag Dec 16, 2024
@kpsherva kpsherva merged commit af193c7 into inveniosoftware:master Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released ✔️
Development

Successfully merging this pull request may close these issues.

2 participants