Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(administration): use html editor for message #33

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

mirekys
Copy link
Contributor

@mirekys mirekys commented Sep 19, 2024

Description

This PR uses Sanitized HTML WYSIWYG editor instead of raw text input for banner message content to make banner administration more user friendly.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.



class BannerSchema(BaseRecordSchema):
"""Schema for banners."""

message = fields.String(required=True)
message = SanitizedHTML(required=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, it would be nice to add a test with HTML ☺️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that's good to have, I added one :)

@ntarocco ntarocco mentioned this pull request Nov 1, 2024
@utnapischtim utnapischtim merged commit cb87dc2 into inveniosoftware:master Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants