[#855] 5) wait for decision flow #1171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenekku
force-pushed
the
855_5_wait_for_decision_flow
branch
from
443941e
to
6dcc6ae
Compare
fenekku
force-pushed
the
855_5_wait_for_decision_flow
branch
from
e845d6b
to
17f1e00
Compare
…tend [+] This concludes the 2nd flow of the membership request feature. Remaining flows are - 'waiting for decision' flow - 'making a decision' flow This PR needs to be complemented by: - one in invenio-requests (done) - one in invenio-rdm-records (to do)
…tend [+] This concludes the 2nd flow of the membership request feature. Remaining flows are - 'waiting for decision' flow - 'making a decision' flow This PR needs to be complemented by: - one in invenio-requests (done) - one in invenio-rdm-records (done)
fenekku
force-pushed
the
855_5_wait_for_decision_flow
branch
from
17f1e00
to
67a28b4
Compare
|
Close in favor of #1175 which contains it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #855
Implement the "waiting flow". Consists of 4 things:
show membership requests in community from reviewer's perspective
show membership requests in dashboard from requester's side
don't show membership requests in normal community requests from reviewer's perspective
Side-bonus: serialize links for member API correctly. This allows the cancellation of Invitations from the listing directly:
After this is merged and released: this inveniosoftware/invenio-app-rdm#2757 in invenio-app-rdm should be looked at (invenio-app-rdm one depends on this current one in invenio-communities)
This PR
Previous PRs