Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faircore4eosc #1607

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Faircore4eosc #1607

merged 2 commits into from
Nov 30, 2023

Conversation

alejandromumo
Copy link
Member

@alejandromumo alejandromumo commented Nov 14, 2023

Note to reviewers: 4.2k changes come from the vocabulary for programming languages.

closes inveniosoftware/invenio-swh#20

@alejandromumo alejandromumo force-pushed the faircore4eosc branch 3 times, most recently from 45f47cd to 04c1176 Compare November 28, 2023 16:15
@alejandromumo alejandromumo marked this pull request as ready for review November 28, 2023 17:22
@alejandromumo alejandromumo force-pushed the faircore4eosc branch 2 times, most recently from adc8835 to 38d09b2 Compare November 29, 2023 10:08
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP review

#
# Invenio-RDM is free software; you can redistribute it and/or modify
# it under the terms of the MIT License; see LICENSE file for more details.
"""RDM service component for Software Heritage integration."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""RDM service component for Software Heritage integration."""
"""RDM service component for signals."""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we just have invenio_rdm_records/services/signals.py?

@slint slint merged commit 81ddb1a into inveniosoftware:master Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit from repository to universal source code archive
3 participants