Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit-ui: show detailed backend error messages if present #1741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Draft

deposit-ui: show detailed backend error messages if present #1741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions ..._rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/errors/FormFeedback.js
View file
Open in desktop
Copy link
Member Author

@ptamarit ptamarit May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: react-invenio-deposit also has a FormFeedback.js, but it seems that it's not used since #1276.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// This file is part of Invenio-RDM-Records
// Copyright (C) 2020-2023 CERN.
// Copyright (C) 2020-2024 CERN.
// Copyright (C) 2020-2022 Northwestern University.
// Copyright (C) 2021 Graz University of Technology.
//
Expand Down Expand Up @@ -266,8 +266,20 @@ class DisconnectedFormFeedback extends Component {
</Message.Item>
));

// errors not related to validation, following a different format {status:.., message:..}
const backendErrorMessage = errors.message;
// errors not related to validation, following a different format {status:..., message:..., errors: {field: ..., messages: [...]}}
let backendErrorMessage = errors.message;

// add extra backend error messages related to fields if present
if (backendErrorMessage && errors.errors) {
backendErrorMessage +=
" " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: should we do a bullet-list instead (similar to the usual form validation errors), since it's an array?

errors.errors
.map((error) => {
// Not including `error.field` since it's often redundant with the messages
return error.messages?.join(" ");
})
.join(" ");
}

return (
<Message
Expand Down
Loading