Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers:
i am not sure about the change from pytz to datetime object itself: https://github.com/inveniosoftware/invenio-records/pull/323/files#diff-469dc6e514838423126b5d9cb7f8a97cb5d024fd648dd95a3be624c49a7e720bL99 my problem is that i don't know why the value in this
_serialize
method now has thetz_info
set already. it could be because of the change fromdatetime.utcnow
todatetime.now(UTC)
but i am not sureQUESTION:
i tried to remove the
SQLALCHEMY_DATABASE_URI
variable from the test.yml file, but it didn't work. there are other packages out there which don't need this variable. why is it that this packages needs this variable. the problem was, that mysql used the postgresql URI without setting the mysql URI explicitly