Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: dev dependencies update #79

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

jmartinm
Copy link
Member

Signed-off-by: Javier Martin Montull [email protected]

@drjova
Copy link
Member

drjova commented Nov 21, 2016

LGTM

@drjova drjova self-assigned this Nov 21, 2016
@drjova
Copy link
Member

drjova commented Nov 21, 2016

@jmartinm just one small thing, could you please update the travis node versions
https://github.com/inveniosoftware/invenio-search-js/blob/master/.travis.yml#L32?

According to https://github.com/nodejs/LTS#lts-schedule we can leave only the latest releases https://nodejs.org/en/download/releases:

  • 0.12
  • 4.6.2
  • 5.12.0
  • 6.9.1
  • 7.1.0

Thanks :)

* Updates dev dependencies to support NodeJS 7.x. (closes inveniosoftware#78)

* Amends .travis.yml node versions to only contain latest releases.

Signed-off-by: Javier Martin Montull <[email protected]>
@jmartinm jmartinm force-pushed the update-dev-dependencies branch from b943b0a to 4f7f7bb Compare November 21, 2016 14:08
@jmartinm
Copy link
Member Author

@drjova just submitted the changes with the new Travis matrix. It makes sense to at least test 7.1.0 since that was the point of this PR :P

Let's see if it passes correctly.

@drjova
Copy link
Member

drjova commented Nov 21, 2016

🎉

@drjova drjova merged commit 4f7f7bb into inveniosoftware:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs v7.1.0 errors on gulp commands
2 participants