-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SalesOrderShipment model #2199
Merged
SchrodingersGat
merged 68 commits into
inventree:master
from
SchrodingersGat:partial-shipment
Dec 4, 2021
Merged
Create SalesOrderShipment model #2199
SchrodingersGat
merged 68 commits into
inventree:master
from
SchrodingersGat:partial-shipment
Dec 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
SchrodingersGat
added
api
Relates to the API
enhancement
This is an suggested enhancement or new feature
stock
Related to Stock models
order
Related to purchase orders / sales orders
and removed
stock
Related to Stock models
labels
Oct 25, 2021
- If a SalesOrder is "PENDING" or there are allocations available, a shipment is created
- Deleting a "Shipment" will delete any "Allocation" objects which reference it - Improve existing data migration for new shipment model
- Filter by order - Filter by "shipped" status - SalesOrderShipment serializer includes information on items allocated to that shipment
- Must be unique - Auto-incrementing default value - Updated migrations
- SalesOrderAllocations are no longer created manually - API endpoint performs data validation - Multiple line items can be allocated at once - Adds unit testing for new API endpoint
- Added model renderer for SalesOrderShipment - Some refactorin'
- From the "New Shipment" button - As a secondary modal from the stock allocation dialgo
- Is not yet implemented in the db model
# Conflicts: # InvenTree/build/templates/build/build_base.html # InvenTree/order/templates/order/order_base.html # InvenTree/order/templates/order/sales_order_base.html # InvenTree/order/templates/order/sales_order_detail.html # InvenTree/order/templates/order/so_navbar.html
Merged
# Conflicts: # InvenTree/InvenTree/version.py # InvenTree/order/models.py
- Pass tracking number through when completing a shipment - Reload tables automatically when certain actions are performed - Limit stock items to only those with available stock
42 tasks
- Allow filtering of salesorderlineitem by "completed" status - Allow deletion of (empty) shipment - Show which items are going to be shipped
# Conflicts: # InvenTree/order/serializers.py
- User might want to add more line items?
# Conflicts: # InvenTree/order/api.py
@SchrodingersGat pumped for this |
SchrodingersGat
added a commit
to inventree/inventree-docs
that referenced
this pull request
Dec 4, 2021
@matmair merged in now, please let me know if you spot any issues, there are a lot of changes here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Relates to the API
enhancement
This is an suggested enhancement or new feature
order
Related to purchase orders / sales orders
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2187
Ref: #1425
This PR implements a "Shipment" model for sales orders, allowing outgoing orders to be partially shipped.
TODO
Add "status" field to SalesOrderShipment modelImplement "Shipment Detail" pageImplement "cancel" endpoint for SalesOrderShipment- will be fixed in [FR] Convert more server-side forms to the API #2253