Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting more forms to the API #2931

Merged
merged 20 commits into from
May 4, 2022
Merged

Converting more forms to the API #2931

merged 20 commits into from
May 4, 2022

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented May 4, 2022 •
edited
Loading

Converted

  • PurchaseOrderCancel
  • PurchaseOrderComplete
  • PurchaseOrderIssue
  • SalesOrderCancel
  • BuildOrderCancel
  • StockItemUninstall

Unit Tests

  • PurchaseOrderCancel
  • PurchaseOrderComplete
  • PurchaseOrderIssue
  • SalesOrderCancel
  • BuildOrderCancel
  • StockItemUninstall

Ref: #2253

@SchrodingersGat SchrodingersGat added the api Relates to the API label May 4, 2022
@SchrodingersGat SchrodingersGat added this to the 0.7.0 milestone May 4, 2022
@SchrodingersGat SchrodingersGat mentioned this pull request May 4, 2022
Closed
42 tasks
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature user interface labels May 4, 2022
@matmair
Copy link
Member

matmair commented May 4, 2022 •
edited
Loading

@SchrodingersGat while total coverage went up, unit coverage is lower now. Maybe we need to add some tests?
Edit: Just saw the new todos

@SchrodingersGat
Add unit tests for new purchase order API endpoints:
7a5be35 
- PurchaseOrderCancel
- PurchaseOrderComplete
- PurchaseOrderIssue
@SchrodingersGat
Add unit test for SalesOrderCancel API endpoint
1c0fba0
@SchrodingersGat
More unit tests
82541ed 
- BuildOrderCancel
- StockItemInstall
- StockItemUninstall
@SchrodingersGat SchrodingersGat merged commit 1dee578 into inventree:master May 4, 2022
@SchrodingersGat SchrodingersGat deleted the more-api-functionality branch May 4, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchrodingersGat @matmair