-
-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove django-allauth-2fa, dj-rest-auth and django-user-sessions #6293
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…matmair/issue6281
…matmair/issue6281
@SchrodingersGat @wolflu05 this is getting close; if you have time I would appreciate feedback on this already |
@matmair this looks like a fantastic improvement. I really appreciate that we can remove a lot of custom auth functionality here. Have you performed any SSO testing as part of this? Is there any way that we can implement some automated CI testing of SSO auth somehow? |
@SchrodingersGat I hope to get most if not all our custom things upstreamed - I am looking into contributing a few different things that we have built for ourselves up to django-allauth, send my first suggestion regarding this a few hours ago. This will help with better-separating concerns between different components. I have tested SSO with GitHub and a few different OIDC providers extensively throughout working on this. We are not modifying the logic around this in any way so allauths tests should cover it. Adding CI testing would probably entail staging credentials for some provider into the CI - I am instinctively not a fan regarding this. I have not looked into that in more depth because we are just consuming the APIs. |
All flows are now ported, now it is about cleanup and finishing a few smaller todos |
…matmair/issue6281
…matmair/issue6281
This PR remove django-allauth-2fa and replaces it with the inline functions of django-allauth. This reduces the dependency footprint and eliminates a bunch of custom creations.
Update: Most of the planned things we would be interested in are now implemented and the scope shifted a bit - it makes sense to just ripp all auth extensions out and use only allauths built-in things. We have a lot of grown auth-adjacent code that can probably be removed/rewritten.
Closes #6281
Closes #8708
Todo: